[core] Refactoring LocalObjectManager to have a cleaner API for pinning objects. #54255
+255
−267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
objects. Signed-off-by: irabbani <[email protected]>
israbbani
commented
Jul 1, 2025
| // executing. | ||
| if (*result_it == nullptr || | ||
| local_object_manager_.ObjectPendingDeletion(*object_id_it)) { | ||
| RAY_LOG(DEBUG).WithField(*object_id_it) |
There was a problem hiding this comment.
Promoting this to INFO. It's not adding a new log line per se. It used to happen inside LocalObjectManager::PinObjectsAndWaitForFree.
|
This pull request has been automatically marked as stale because it has not had You can always ask for help on our discussion forum or Ray's public slack channel. If you'd like to keep this open, just leave any comment, and the stale label will be removed. |
github-actions
bot
added
the
stale
israbbani
added
unstale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #53934. It's pure refactoring:
LocalObjectManager::PinObjectsAndWaitForFreewith a new API that has a cleaner interface (returns a Status)