[core] Remove actor task path in normal task submitter #53996
Merged
+17
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dayshah <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR removes the actor task path in the normal task submitter by eliminating actor-specific logic and updating related client cache usage.
- Removes the is_actor parameter from functions and lambda captures.
- Replaces the client_cache_ member with core_worker_client_pool_ across the NormalTaskSubmitter implementation.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ray/core_worker/transport/normal_task_submitter.h | Updates constructor initialization and removes inline specifier for CheckNoSchedulingKeyEntries; replaces client_cache_ with core_worker_client_pool_. |
| src/ray/core_worker/transport/normal_task_submitter.cc | Replaces client_cache_ usage with core_worker_client_pool_ and removes actor-specific parameters in task failure handling and task submission. |
Comments suppressed due to low confidence (1)
src/ray/core_worker/transport/normal_task_submitter.cc:605
- Verify that the removal of the actor-specific flag (is_actor) from the error handling call is appropriate and that the new error type mapping covers all intended scenarios.
task_id,
codope
reviewed
Jun 23, 2025
| @@ -690,13 +686,12 @@ void NormalTaskSubmitter::HandleGetTaskFailureCause( | |||
| error_info->set_error_message(buffer.str()); | |||
| error_info->set_error_type(rpc::ErrorType::NODE_DIED); | |||
| } | |||
| RAY_UNUSED(task_finisher_.FailOrRetryPendingTask( | |||
| task_id, | |||
| is_actor ? rpc::ErrorType::ACTOR_DIED : task_error_type, | |||
There was a problem hiding this comment.
is_actor -- was this ever true in normal_task_submitter?
There was a problem hiding this comment.
maybe a long time ago there was only one submitter? i don't rlly know
There was a problem hiding this comment.
the question is if is_actor is ever currently true here in the current state of the code
edoakes
approved these changes
Jun 23, 2025
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Jun 27, 2025
…3996) Actor tasks are never submitted into the normal task submitter and never should be. This removes that path and asserts it. Also changing a variable name from `client_cache_` to `core_worker_client_pool_`. Signed-off-by: dayshah <[email protected]>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
Actor tasks are never submitted into the normal task submitter and never should be. This removes that path and asserts it. Also changing a variable name from `client_cache_` to `core_worker_client_pool_`. Signed-off-by: dayshah <[email protected]> Signed-off-by: elliot-barn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Actor tasks are never submitted into the normal task submitter and never should be. This removes that path and asserts it.
Also changing a variable name from
client_cache_tocore_worker_client_pool_.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.