[serve] Fix runtime_env validation for py_modules #53186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoakes
approved these changes
May 21, 2025
There was a problem hiding this comment.
nonblocking comment
cc @israbbani because this is related to the PR you sent me earlier today
python/ray/serve/schema.py
Outdated
| @@ -260,8 +260,8 @@ def runtime_env_contains_remote_uris(cls, v): | |||
| if v is None: | |||
| return | |||
|
|
|||
| uris = v.get("py_modules", []) | |||
| if "working_dir" in v and v["working_dir"] not in uris: | |||
| uris = v.get("py_modules", []).copy() | |||
There was a problem hiding this comment.
.copy() is a shallow copy. currently for py_modules this should be fine, but probably safer to do copy.deepcopy() just to be paranoid since there shouldn't be any performance concern here
There was a problem hiding this comment.
Thanks, I made the whole thing nondestructive now, that's probably the clearest solution for a validation function like this and also needs less allocations than a deepcopy would need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This fixes the fix #41688 -- that fix was the wrong fix since the validation should never change the runtime_env.
It introduced the problem in https://discuss.ray.io/t/query-application-status-api-triggers-re-deployment/22517
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.