-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[Data] Added support for Joins (using hash-shuffle) #52728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data] Added support for Joins (using hash-shuffle) #52728
Conversation
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
python/ray/data/dataset.py
Outdated
TorchBatchType = Union[Dict[str, "torch.Tensor"], CollatedData] | ||
|
||
BT_API_GROUP = "Basic Transformations" | ||
J_API_GROUP = "Joining Operation APIs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be part of SMD_API_GROUP, which would include zip/merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, i can add to that group but i don't really understand the intention behind this grouping as it seems practically arbitrary in many cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the grouping names gets rendered for documentation for better user discovery (grouping APIs into subsections).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!!
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Why are these changes needed?
This PR adds
Dataset.join
operator allowing 2 datasets to be joined using previously added Hash-shuffle implementation.Currently following types of joins are supported:
In the future we'll be adding support for more join types.
Changes
JoinOperator
Dataset.join
Related issue number
Closes #18911 (Finally!!!)
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.