Skip to content

Conversation

MortalHappiness
Copy link
Member

Why are these changes needed?

This PR converts TrainHead to subprocess module.

Related issue number

N/A

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@MortalHappiness MortalHappiness added the go add ONLY when ready to merge, run all tests label Apr 4, 2025
@MortalHappiness MortalHappiness marked this pull request as ready for review April 4, 2025 09:46
Co-authored-by: Jiajun Yao <[email protected]>
Signed-off-by: Chi-Sheng Liu <[email protected]>
@MortalHappiness MortalHappiness marked this pull request as draft April 5, 2025 01:48
Signed-off-by: Chi-Sheng Liu <[email protected]>
Signed-off-by: Chi-Sheng Liu <[email protected]>
@MortalHappiness MortalHappiness marked this pull request as ready for review April 5, 2025 01:52
@jjyao jjyao merged commit 6a5bf8b into ray-project:master Apr 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-backlog go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants