Skip to content

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Mar 19, 2025

Why are these changes needed?

This adds nice integrations between Daft and Ray Data along with:

Unit test for data round-trip (including more interesting types such as a Tensor)
Documentation
Implementation on Ray Dataset for conversion to/from Daft Dataframes

Related issue number

Re-opening #50630 which was borked by a bad rebase.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jaychia jaychia requested review from a team as code owners March 19, 2025 19:27
@jaychia jaychia force-pushed the jay/daft-integration branch from 9294f0d to c15529f Compare March 19, 2025 19:28
@richardliaw richardliaw added the go add ONLY when ready to merge, run all tests label Mar 19, 2025
@jcotant1 jcotant1 added the data Ray Data-related issues label Mar 19, 2025
Signed-off-by: Jay Chia <[email protected]>
@jaychia jaychia force-pushed the jay/daft-integration branch from 3b1faf4 to 28e519f Compare March 19, 2025 22:43
jaychia added 2 commits March 19, 2025 15:50
Signed-off-by: Jay Chia <[email protected]>
Signed-off-by: Jay Chia <[email protected]>
@jaychia jaychia force-pushed the jay/daft-integration branch from c973a14 to a19970e Compare March 19, 2025 22:50
Signed-off-by: Jay Chia <[email protected]>
@jaychia jaychia force-pushed the jay/daft-integration branch from 506a7be to 1d8c7ac Compare March 23, 2025 00:43
@richardliaw richardliaw enabled auto-merge (squash) March 25, 2025 16:17
Signed-off-by: Richard Liaw <[email protected]>
@github-actions github-actions bot disabled auto-merge March 26, 2025 01:32
@richardliaw richardliaw self-assigned this Mar 26, 2025
@richardliaw richardliaw merged commit ff1ecbe into ray-project:master Mar 26, 2025
5 checks passed
dhakshin32 pushed a commit to dhakshin32/ray that referenced this pull request Mar 27, 2025
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

This adds nice integrations between Daft and Ray Data along with:

Unit test for data round-trip (including more interesting types such as
a Tensor)
Documentation
Implementation on Ray Dataset for conversion to/from Daft Dataframes

## Related issue number

Re-opening ray-project#50630 which was borked by a bad rebase.

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [x] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [x] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: Jay Chia <[email protected]>
Signed-off-by: Richard Liaw <[email protected]>
Co-authored-by: Richard Liaw <[email protected]>
Signed-off-by: Dhakshin Suriakannu <[email protected]>
srinathk10 pushed a commit that referenced this pull request Mar 28, 2025
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

This adds nice integrations between Daft and Ray Data along with:

Unit test for data round-trip (including more interesting types such as
a Tensor)
Documentation
Implementation on Ray Dataset for conversion to/from Daft Dataframes

## Related issue number

Re-opening #50630 which was borked by a bad rebase.

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [x] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [x] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: Jay Chia <[email protected]>
Signed-off-by: Richard Liaw <[email protected]>
Co-authored-by: Richard Liaw <[email protected]>
Signed-off-by: Srinath Krishnamachari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-backlog data Ray Data-related issues go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants