Remove unnecessary string literal splits #47360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryant1410
requested review from
hongpeng-guo,
justinvyu,
matthewdeng,
raulchen,
woshiyyya,
architkulkarni,
maxpumperla,
pcmoritz,
kevin85421,
a team,
sven1977,
ArturNiederfahrenhorst,
simonsays1980,
ericl,
scv119,
c21,
amogkam,
scottjlee,
bveeramani,
stephanie-wang and
omatthew98
as code owners
bryant1410
force-pushed
the
remove-spurious-spaces
branch
from
4cca447 to
9eebb52
Compare
anyscalesam
added
dashboard
|
@bryant1410 can you rebase? many of these may already be fixed |
ruisearch42
added
the
@external-author-action-required
bryant1410
force-pushed
the
remove-spurious-spaces
branch
from
9eebb52 to
8a760f0
Compare
bryant1410
force-pushed
the
remove-spurious-spaces
branch
2 times, most recently
from
494951e to
acd363c
Compare
Signed-off-by: Santiago Castro <[email protected]>
bryant1410
force-pushed
the
remove-spurious-spaces
branch
from
acd363c to
64a029f
Compare
done |
crypdick
requested changes
Apr 3, 2025
There was a problem hiding this comment.
@bryant1410 thank you for your contribution! can you please run the code formatter to make our linter checks pass, then we should be good to go!
Signed-off-by: Santiago Castro <[email protected]>
done |
bryant1410
force-pushed
the
remove-spurious-spaces
branch
from
451d70f to
2d29116
Compare
Signed-off-by: Santiago Castro <[email protected]>
bryant1410
force-pushed
the
remove-spurious-spaces
branch
2 times, most recently
from
d5f28fa to
5157de7
Compare
pcmoritz
approved these changes
Apr 7, 2025
|
@bryant1410 Thanks a lot for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found there were a bunch. Found them with: