Skip to content

Fixed bug in GooglePeople class - Retrieve Contacts without contacts #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
villalvilla wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed bug in GooglePeople class - Retrieve Contacts without contacts #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions src/GooglePeople.php
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,25 +67,28 @@ public function all()

$contacts = [];

foreach($responseObj->connections as $connection) {
$contacts[] = $this->convertResponseConnectionToContact($connection);
}
if (isset($responseObj) && is_object($responseObj) && is_array($responseObj->connections)) {

foreach($responseObj->connections as $connection) {
$contacts[] = $this->convertResponseConnectionToContact($connection);
}

while(isset($responseObj->nextPageToken)) {
while(isset($responseObj->nextPageToken)) {

$url = self::PEOPLE_BASE_URL.'people/me/connections?personFields='.implode(',', self::PERSON_FIELDS).'&pageSize=2000&pageToken='.$responseObj->nextPageToken;
$url = self::PEOPLE_BASE_URL.'people/me/connections?personFields='.implode(',', self::PERSON_FIELDS).'&pageSize=2000&pageToken='.$responseObj->nextPageToken;

$response = $this->googleOAuth2Handler->performRequest('GET', $url);
$body = (string) $response->getBody();
$response = $this->googleOAuth2Handler->performRequest('GET', $url);
$body = (string) $response->getBody();

if ($response->getStatusCode()!=200) {
throw new Exception($body);
}
if ($response->getStatusCode()!=200) {
throw new Exception($body);
}

$responseObj = json_decode($body);
$responseObj = json_decode($body);

foreach($responseObj->connections as $connection) {
$contacts[] = $this->convertResponseConnectionToContact($connection);
foreach($responseObj->connections as $connection) {
$contacts[] = $this->convertResponseConnectionToContact($connection);
}
}
}

Expand Down