Skip to content

Conversation

robertmaynard
Copy link
Contributor

Description

Updates rapids-cmake as required to implement the new RAPIDS branching strategy as outlined at: https://github.com/rapidsai/ops/issues/3935#issuecomment-3058629171

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.

…pidsai#864)

To support the new RAPIDS wide branching model rapids-cmake has to support switching between the `main` branch for `rapids_cpm_rmm` and a release branch like `branch-25.06`.

This is implemented by reading the rapids-cmake `VERSION` file and when we detect a value that ends in `a` we know we are being used from the `main` branch (a development version) and not from a release branch.

Fixes rapidsai#863

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Bradley Dice (https://github.com/bdice)

URL: rapidsai#864
@robertmaynard robertmaynard requested review from a team as code owners July 15, 2025 15:51
@robertmaynard robertmaynard requested review from gforsyth and removed request for a team July 15, 2025 15:51
Copy link
Contributor

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving the CI changes

@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change labels Jul 15, 2025
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit eb2b934 into rapidsai:branch-25.08 Jul 21, 2025
12 checks passed
@robertmaynard robertmaynard deleted the use_rapids_branch_file branch July 21, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants