Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.

Conversation

@bdice
Copy link
Contributor

@bdice bdice commented Mar 7, 2025

@bdice bdice requested review from a team as code owners March 7, 2025 21:40
@bdice bdice requested a review from AyodeAwe March 7, 2025 21:40
@bdice bdice merged commit a74752c into rapidsai:main Mar 7, 2025
49 checks passed
@vyasr
Copy link
Contributor

vyasr commented Mar 7, 2025

@webknjaz apologies for another direct ping, but this is sort of a follow up to the work you've seen us doing in e.g. NVIDIA/numba-cuda#147 as we attempt to get everything using the workflow correctly. We've tried switching this repository to also use the GH runners to do a publish, but we're still seeing failures in https://github.com/rapidsai/pynvjitlink/actions/runs/13730908249/job/38407961979. We are indeed using a GH runner now (and we're certainly requesting one). My assumption is that we're seeing failures because we are using a container on top of the image, and I'm guessing that is also not supported. Is there any safe way for us to do this (e.g. by mounting something from the host into the container) or do we have to run bare metal on the runner?

Thanks in advance for any help you can give us!

@webknjaz
Copy link

webknjaz commented Mar 8, 2025

@vyasr that's unsupported and yes, that's likely because of the container. You could probably hack it somehow but I don't recommend it. Even if you somehow work around it, you'll hit another crash when you get to using Trusted publishing with digital attestations, because you're running it from a reusable workflow. It just won't work.
It is supposed to be the only thing running in the job, in the default runner. Nothing else is tested. And some things we can't even put into our CI.
As I said elsewhere, it must be in the top-level workflow. And the OIDC privilege would just be elevated for that job.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants