add shellcheck to pre-commit #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Lamb <[email protected]>
jameslamb
added
improvement
32 tasks
gforsyth
approved these changes
Jun 12, 2025
RAMitchell
pushed a commit
to RAMitchell/legate-dataframe
that referenced
this pull request
Jun 17, 2025
## Description Contributes to rapidsai/build-planning#135 Adds `shellcheck` to `pre-commit`, to catch issues like unsafe access patterns, unused variables, etc. in shell scripts. Fixes these warnings: ```text SC2046 (warning): Quote this to prevent word splitting. SC2068 (error): Double quote array expansions to avoid re-splitting elements ``` ## Checklist - [x] New or existing tests cover these changes. - [x] The documentation is up to date with these changes. - [ ] Run `./build.sh test` for local testing, see [CONTRIBUTING.md](https://github.com/rapidsai/legate-dataframe/blob/main/CONTRIBUTING.md#testing). - [x] Ensure `pre-commit` checks are passing see [CONTRIBUTING.md](https://github.com/rapidsai/legate-dataframe/blob/main/CONTRIBUTING.md#Pre-commit-hooks). Signed-off-by: James Lamb <[email protected]> Signed-off-by: Rory Mitchell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to rapidsai/build-planning#135
Adds
shellchecktopre-commit, to catch issues like unsafe access patterns, unused variables, etc. in shell scripts.Fixes these warnings:
Checklist
./build.sh testfor local testing, see CONTRIBUTING.md.pre-commitchecks are passing see CONTRIBUTING.md.