Skip to content

Conversation

jameslamb
Copy link
Member

Contributes to rapidsai/build-planning#135

Adds shellcheck to pre-commit, to catch issues like unsafe access patterns, unused variables, etc. in shell scripts.

Fixes these warnings:

SC2102 (info): Ranges can only match single chars (mentioned due to duplicates).
SC2086 (info): Double quote to prevent globbing and word splitting.
SC1091 (info): Not following: rapids-init-pip was not specified as input (see shellcheck -x).
SC1091 (info): Not following: /opt/conda/etc/profile.d/conda.sh was not specified as input (see shellcheck -x).
SC2034 (warning): NEXT_SHORT_TAG appears unused. Verify use (or export if used externally).
SC2034 (warning): CURRENT_SHORT_TAG appears unused. Verify use (or export if used externally).
SC2034 (warning): package_name appears unused. Verify use (or export if used externally).

Also updates all other hooks with pre-commit autoupdate.

@jameslamb jameslamb changed the title WIP: add shellcheck to pre-commit add shellcheck to pre-commit Jun 12, 2025
@jameslamb jameslamb requested a review from gforsyth June 12, 2025 21:00
@jameslamb jameslamb marked this pull request as ready for review June 12, 2025 21:00
@jameslamb jameslamb requested review from a team as code owners June 12, 2025 21:00
@jameslamb
Copy link
Member Author

/merge

1 similar comment
@AyodeAwe
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 7cdc778 into rapidsai:branch-0.14 Jun 13, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants