-
Notifications
You must be signed in to change notification settings - Fork 67
stop uploading to downloads.rapids.ai, add shellcheck #770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stop uploading to downloads.rapids.ai, add shellcheck #770
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
/ok to test |
|
CUDA 12 builds are all failing with some variation of this: CUDA 11 builds have been running for 2+ hours (!!!), stuck on what looks like a conda solve setting up the host environment? Final lines of logs: The latest nightlies failed in the same way... CUDA 11 jobs timed out after 6 hours, CUDA 12 jobs failed complaining about there not being a |
|
/ok to test |
|
The However, it requires at least one copy of that package to exist on the We're at the beginning of the 25.08 release and so there aren't 25.08 packages yet, meaning that check fails:
That could be resolved by admin-merging this PR, but we could also avoid that by the following set of changes:
I'm going to try that. |
|
/ok to test |
|
Looks like dropping CUDA 11 in rapidsai/shared-workflows#371 was the last piece needed for this! Putting it up for review. |
bdice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of me wants to force the use of rapidsai-nightly because otherwise the commands in our installation docs can fail without any signal in CI.
The rapids metapackage is special because it doesn’t get uploaded with successful nightly builds. It is only built manually. In other words, the cold start problem where tests fail for a new release is a feature (forces us to be aware of the missing package), not a bug.
|
Over in the So nightly runs there do give us some signal about dependency issues with the metapackage. But that's a bit indirect, to be fair. Thanks for the explanation, I'll revert those changes here and we can ask for this to be admin-merged. |
|
I've reverted the testing changes here. Once this is passing all the CI besides |
|
/merge |
Description
Contributes to rapidsai/build-planning#181
downloads.rapids.aiContributes to rapidsai/build-planning#135
shellcheckchecks topre-commitconfigurationAlso proposes changes to get around the cold-start problem we have at the beginning of every release, wheretest-conda-nightly-envcannot run because there aren't yet publishedrapidspackages.makestest-conda-nightly-envdependent on the just-built-in-CIrapidspackages, instead of installing them fromrapidsai-nightlyNotes for Reviewers
How I identified changes
Looked for uses of the relevant
gha-toolstools, as well as documentation aboutdownloads.rapids.ai, being on the NVIDIA VPN, using S3, etc. like this:git grep -i -E 's3|upload|downloads\.rapids|vpn'How I tested this
See "How I tested this" on rapidsai/shared-workflows#364