Skip to content

set glab cli git protocol to GIT_PROTOCOL #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: branch-25.10
Choose a base branch
from
Open

set glab cli git protocol to GIT_PROTOCOL #561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2386844
set glab cli git protocol to GIT_PROTOCOL
msarahan Aug 14, 2025
670a9cc
add option to skip pip repo aggregation
msarahan Aug 27, 2025
c8985cc
Merge branch 'branch-25.10' into set_gitlab_protocol
trxcllnt Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions features/src/rapids-build-utils/opt/rapids-build-utils/bin/make-pip-dependencies.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,9 @@ _make_pip_dependencies() {
# shellcheck disable=SC2064
trap "rm -rf '${tmpdir}'" EXIT;

eval "$(rapids-list-repos "${OPTS[@]}")";

if [ -z "${SKIP_RAPIDS_AGGREGATE_PIP_INDEXES}" ]; then
eval "$(rapids-list-repos "${OPTS[@]}")";
fi
Comment on lines +189 to +191
Copy link
Collaborator

@trxcllnt trxcllnt Sep 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be accomplished with an existing flag:

$ rapids-make-pip-dependencies --exclude <(echo '.*')

This passes the file descriptor with the wildcard pattern to grep -E -v.

Alternatively, if you want to exclude all repos but still include the requirements passed via -r,--requirement, use the --repo flag with an empty string:

$ rapids-make-pip-dependencies --repo "" -r <(echo "foo-pkg")
foo-pkg

readarray -t pip_reqs_txts < <(_generate_requirements_txts);

if test ${#requirement[@]} -gt 0 || test ${#pip_reqs_txts[@]} -gt 0; then
Expand Down
2 changes: 2 additions & 0 deletions features/src/utils/opt/devcontainer/bin/gitlab/cli/init.sh
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to bump the feature version

Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ init_gitlab_cli() {
|| echo "Continuing without logging into GitLab";
fi

glab config set git_protocol --host "${GITLAB_HOST:-gitlab.com}" ${GIT_PROTOCOL:-ssh};

local gitlab_user="${GITLAB_USER:-}";

if [ -z "${gitlab_user:-}" ]; then
Expand Down
Loading