[ANN_BENCH] Fix OpenMP Sections in Wrappers #911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
tarang-jain
added
bug
…into threading-modes
Contributor
Author
|
@achirkin @tfeher for viz. Removed number of search threads entirely because user can control it with OpenMP environment variables, which is actually the most correct way of using OpenMP rather than passing in process-specific threads through cuvs-bench. We simply call Faiss' search APIs with the batch of queries and Faiss does all its parallelization internally. |
divyegala
requested changes
Jun 8, 2025
Member
divyegala
left a comment
divyegala
left a comment
There was a problem hiding this comment.
@tarang-jain can you pull #724 into this PR?
Contributor
Author
|
@divyegala #724 has build failures in CI at the moment. |
…into threading-modes
divyegala
approved these changes
Jul 1, 2025
Member
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes OpenMP num thread setting + dispatching search workloads in DiskANN and Faiss CPU cuvs-bench wrappers.
Hnswlib wrapper taken care of in #724