CUVS_ANN_BENCH_SINGLE_EXE: find the mg library #890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for multi-gpu implementations
achirkin
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-25.06 #890 +/- ##
=============================================
Coverage 84.49% 84.49%
=============================================
Files 20 20
Lines 129 129
=============================================
Hits 109 109
Misses 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tfeher
approved these changes
May 20, 2025
Contributor
tfeher
left a comment
tfeher
left a comment
There was a problem hiding this comment.
Thanks for the fix Artem, LGTM.
Contributor
Author
|
/merge |
github-project-automation
bot
moved this from In Progress
to Done
in Vector Search, ML, & Data Mining Release Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let the benchmark in CUVS_ANN_BENCH_SINGLE_EXE mode find the library for multi-gpu implementations.
Originally, all library names coincided with the generated target (library) names, which was used by the loader to find a proper implementation for an algorithm in the benchmark config.
A group of cuVS mg algorithms broke this pattern by using a single target for all cuVS mg algorithms. This PR adds this exception for the library discovery logic.