Specify matplotlib version #839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For security scanning we've been asked to specify a version for matplotlib, so require at least matplotlib 3.9 since according its the oldest still supported release of matplotlib for security patches
benfred
added
improvement
cjnolet
approved these changes
Apr 23, 2025
gforsyth
approved these changes
Apr 24, 2025
Contributor
gforsyth
left a comment
gforsyth
left a comment
There was a problem hiding this comment.
Approving to unblock, but note that if you want to also add this lower bound to the conda packages you'll have to edit the conda/*/recipe.yaml files separately.
KyleFromNVIDIA
approved these changes
Apr 24, 2025
jakirkham
requested changes
Apr 24, 2025
Member
jakirkham
left a comment
jakirkham
left a comment
There was a problem hiding this comment.
Thanks Ben! 🙏
Let's go ahead and update the Conda recipes here with the other changes
…ed/cuvs into specify-matplotlib-version
jakirkham
approved these changes
Apr 24, 2025
Member
Author
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For security scanning we've been asked to specify a version for matplotlib, so require at least matplotlib 3.9 since according to https://github.com/matplotlib/matplotlib/security its the oldest still supported release of matplotlib