Skip to content

Conversation

@achirkin
Copy link
Contributor

Replace all hard-coded index file names in tests with a randomly-generated unique paths in the system temporary folder and delete the files after use.

This is a slightly opinionated convenience PR to give the following benefits:

  • Temporary index files do not clutter the project folder
  • One can run multiple test instances in parallel without the danger of data corruption (e.g. for stress-testing)
  • The tests do not fail if the current folder is read-only

@achirkin achirkin added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Apr 23, 2025
@achirkin achirkin self-assigned this Apr 23, 2025
@achirkin achirkin requested a review from a team as a code owner April 23, 2025 08:40
@github-actions github-actions bot added the cpp label Apr 23, 2025
@achirkin
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c3a77ec into rapidsai:branch-25.06 Apr 24, 2025
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cpp improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Development

Successfully merging this pull request may close these issues.

2 participants