Remove unused raft cagra header in add_nodes.cuh #741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
added
improvement
Member
|
/ok to test |
1 similar comment
Member
|
/ok to test |
Vector search headers in raft will be removed in the future, so we should not include the raft cagra header.
tarang-jain
reviewed
Apr 18, 2025
Contributor
tarang-jain
left a comment
tarang-jain
left a comment
There was a problem hiding this comment.
Can you rebase to 25.06?
Member
|
/ok to test 61652af |
Member
|
/merge |
Member
|
/ok to test 156125b |
cjnolet
approved these changes
May 28, 2025
Member
|
/merge |
github-project-automation
bot
moved this from In Progress
to Done
in Vector Search, ML, & Data Mining Release Board
mythrocks
pushed a commit
to mythrocks/cuvs
that referenced
this pull request
Jun 3, 2025
Vector search headers in raft will be removed in the future, so we should not include the raft cagra header. Authors: - Yinzuo Jiang (https://github.com/jiangyinzuo) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#741
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vector search headers in raft will be removed in the future, so we should not include the raft cagra header.