[Feat] Expose search with bitset C API for Brute Force #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add python APi and update doc for python API
rhdong
added
feature request
This reverts commit 211deb5.
This reverts commit c28e95f.
rapids-bot bot
pushed a commit
that referenced
this pull request
Mar 4, 2025
#695 introduced a conda dependency on `"sklearn"`. There is no `sklearn`... the package is called `scikit-learn`. This fixes that. ## Notes for Reviewers ### How this fixes CI On #738, @rhdong was facing the following problem. The `conda-cpp-build` jobs were producing packages with version `25.04.00a94`: ```text BUILD START: ['libcuvs-25.04.00a94-cuda11_250303_g2ffe160_94.conda', 'libcuvs-static-25.04.00a94-cuda11_250303_g2ffe160_94.conda', 'libcuvs-examples-25.04.00a94-cuda11_250303_g2ffe160_94.conda', 'libcuvs-tests-25.04.00a94-cuda11_250303_g2ffe160_94.conda'] ``` ([logs link](https://github.com/rapidsai/cuvs/actions/runs/13636442011/job/38116419908?pr=738#step:9:489)) But at test time, they were getting `25.05.00a84`: ```text ... libcuvs 25.04.00a84 cuda11_250224_ga1e0cc0_84 rapidsai-nightly ``` ([logs link](https://github.com/rapidsai/cuvs/actions/runs/13636442011/job/38125502858?pr=738#step:9:4583)) It looks like this `sklearn` dependency was the root cause, as explained in #743 (comment) Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Ben Frederickson (https://github.com/benfred) - Bradley Dice (https://github.com/bdice) URL: #743
jiangyinzuo
pushed a commit
to jiangyinzuo/cuvs
that referenced
this pull request
Mar 27, 2025
rapidsai#695 introduced a conda dependency on `"sklearn"`. There is no `sklearn`... the package is called `scikit-learn`. This fixes that. ## Notes for Reviewers ### How this fixes CI On rapidsai#738, @rhdong was facing the following problem. The `conda-cpp-build` jobs were producing packages with version `25.04.00a94`: ```text BUILD START: ['libcuvs-25.04.00a94-cuda11_250303_g2ffe160_94.conda', 'libcuvs-static-25.04.00a94-cuda11_250303_g2ffe160_94.conda', 'libcuvs-examples-25.04.00a94-cuda11_250303_g2ffe160_94.conda', 'libcuvs-tests-25.04.00a94-cuda11_250303_g2ffe160_94.conda'] ``` ([logs link](https://github.com/rapidsai/cuvs/actions/runs/13636442011/job/38116419908?pr=738#step:9:489)) But at test time, they were getting `25.05.00a84`: ```text ... libcuvs 25.04.00a84 cuda11_250224_ga1e0cc0_84 rapidsai-nightly ``` ([logs link](https://github.com/rapidsai/cuvs/actions/runs/13636442011/job/38125502858?pr=738#step:9:4583)) It looks like this `sklearn` dependency was the root cause, as explained in rapidsai#743 (comment) Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Ben Frederickson (https://github.com/benfred) - Bradley Dice (https://github.com/bdice) URL: rapidsai#743
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.