Reduce memory consumption of scalar quantizer #736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfeher
added
improvement
tfeher
changed the title
tfeher
reviewed
Feb 28, 2025
Contributor
tfeher
left a comment
tfeher
left a comment
There was a problem hiding this comment.
Thanks Malte, it looks good, just one comment below.
tfeher
approved these changes
Mar 17, 2025
Contributor
tfeher
left a comment
tfeher
left a comment
There was a problem hiding this comment.
Thanks Malte for the update, LGTM.
Contributor
|
/merge |
divyegala
pushed a commit
to divyegala/cuvs
that referenced
this pull request
Mar 21, 2025
This is an optimization raised by rapidsai#718 . The quantile selection process currently relies on sampling. The memory requirements for the originally used `raft::random::sample_without_replacement` are roughly `48*input_len bytes` (`4*len*8byte + ~2*len*8byte for sort`). This has now been replaced by `raft::matrix::sample_rows` which essentially has the same requirement but based on the sample size instead of the original input. Authors: - Malte Förster (https://github.com/mfoerste4) Approvers: - Tamas Bela Feher (https://github.com/tfeher) URL: rapidsai#736
jiangyinzuo
pushed a commit
to jiangyinzuo/cuvs
that referenced
this pull request
Mar 27, 2025
This is an optimization raised by rapidsai#718 . The quantile selection process currently relies on sampling. The memory requirements for the originally used `raft::random::sample_without_replacement` are roughly `48*input_len bytes` (`4*len*8byte + ~2*len*8byte for sort`). This has now been replaced by `raft::matrix::sample_rows` which essentially has the same requirement but based on the sample size instead of the original input. Authors: - Malte Förster (https://github.com/mfoerste4) Approvers: - Tamas Bela Feher (https://github.com/tfeher) URL: rapidsai#736
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an optimization raised by #718 .
The quantile selection process currently relies on sampling. The memory requirements for the originally used
raft::random::sample_without_replacementare roughly
48*input_len bytes(4*len*8byte + ~2*len*8byte for sort).This has now been replaced by
raft::matrix::sample_rowswhich essentially has the same requirement but based on the sample size instead of the original input.