-
Notifications
You must be signed in to change notification settings - Fork 143
[Feat] Expose search with bitset C API for Brute Force #717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
benfred
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks great - thanks for submitting!
Can we get this exposed to python as well? This might only involve updating the documentation and adding a unittest (and since cagra/ivf-flat share the same test
cuvs/python/cuvs/cuvs/tests/test_ivf_flat.py
Lines 138 to 140 in a2a6a67
| @pytest.mark.parametrize("sparsity", [0.5, 0.7, 1.0]) | |
| def test_filtered_ivf_flat(sparsity): | |
| run_filtered_search_test(ivf_flat, sparsity) |
Hi @benfred, thank you for your time. After studying our code, I believe there should be no need to change the Python API, and I just updated the doc work for |
cjnolet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Amazing, the failure log shows the code being tested is old.. had to rerun.. |
|
/ok to test |
|
/merge |
Authors: - rhdong (https://github.com/rhdong) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - Ben Frederickson (https://github.com/benfred) URL: rapidsai#717
No description provided.