Skip to content

Conversation

@benfred
Copy link
Member

@benfred benfred commented Feb 5, 2025

No description provided.

@benfred benfred requested review from a team as code owners February 5, 2025 18:23
@benfred benfred self-assigned this Feb 5, 2025
@benfred benfred added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Feb 5, 2025
* @param[in] dataset a row-major host or device matrix to transform
* @param[out] out a row-major host or device matrix to store transformed data
*/
cuvsError_t cuvsBinaryQuantizerTransform(cuvsResources_t res,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a little note here that bitwise_hamming distance needs to be used w/ binary quantized data?

add an example using binary quantizer with the bitwisehamming cagra
index
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@benfred
Copy link
Member Author

benfred commented Feb 6, 2025

/merge

@rapids-bot rapids-bot bot merged commit bf86cde into rapidsai:branch-25.02 Feb 6, 2025
64 of 65 checks passed
@benfred benfred deleted the binary_quantizer_python branch February 7, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake cpp improvement Improves an existing functionality non-breaking Introduces a non-breaking change Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants