Skip to content

Conversation

@vyasr
Copy link
Contributor

@vyasr vyasr commented Dec 31, 2024

As part of #528 cuvs's doc builds were modified to pull Breathe from pip. That was necessary because the nvidia-sphinx-theme requires Sphinx 8 but the conda-forge Breathe package was not compatible with that Sphinx version. I fixed that in conda-forge/breathe-feedstock#64, so now we can go back to using Breathe from conda to avoid mixing pip and conda for dependency management in the same environment.

@vyasr vyasr added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Dec 31, 2024
@vyasr vyasr self-assigned this Dec 31, 2024
@vyasr vyasr requested a review from a team as a code owner December 31, 2024 00:22
@vyasr vyasr requested a review from gforsyth December 31, 2024 00:22
@vyasr
Copy link
Contributor Author

vyasr commented Dec 31, 2024

/merge

@rapids-bot rapids-bot bot merged commit 55c5a7f into rapidsai:branch-25.02 Dec 31, 2024
58 checks passed
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this pull request Dec 31, 2024
See rapidsai/cuvs#554, the switch to pip for Breathe in #4839 is no longer required.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #4842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants