Skip to content

Conversation

@jameslamb
Copy link
Member

@jameslamb jameslamb commented Dec 3, 2024

Wheel-building CI jobs are failing like this:

Checking final_dist/cuvs_cu12-25.2.0a26-cp310-cp310-manylinux_2_28_aarch64.whl: FAILED due to warnings
WARNING long_description missing.
Error: Process completed with exit code 1.

(build link)

Looks like the root cause is a combination of the following:

This proposes adding a small README, with just 2 sentences copied from the project's root-level README, to get past that check.

Notes for Reviewers

The long_description becomes the project homepage when a project is hosted on PyPI. The wheels produced from this repo aren't currently being published to pypi.org so this change won't be seen there, but a more user-friendly README should be added if/when we decide to publish cuvs-cu{11,12} to pypi.org.

ref: rapidsai/build-planning#70

@github-actions github-actions bot added the Python label Dec 3, 2024
@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change and removed Python labels Dec 3, 2024
@jameslamb jameslamb changed the title WIP: add a README for wheels add a README for wheels Dec 3, 2024
@jameslamb jameslamb marked this pull request as ready for review December 3, 2024 20:20
@jameslamb jameslamb requested a review from a team as a code owner December 3, 2024 20:20
@raydouglass raydouglass merged commit e0aebfd into rapidsai:branch-24.12 Dec 3, 2024
29 of 30 checks passed
@jameslamb jameslamb deleted the fix-readme branch December 3, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants