Add serialization API to brute-force #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowener
added
feature request
cjnolet
reviewed
Nov 15, 2024
cjnolet
reviewed
Nov 20, 2024
cjnolet
reviewed
Nov 20, 2024
| /** | ||
| * Save the index to file. | ||
| * | ||
| * Experimental, both the API and the serialization format are subject to change. |
Member
There was a problem hiding this comment.
We may be able to remove this now (everywhere). This API has been around for awhile in RAFT and in the other indexes.
Contributor
Author
There was a problem hiding this comment.
I removed the mention of experimental, but I still kept the mention that the serialization format can be subject to changes to not have users expect retro-compatibility.
cjnolet
reviewed
Nov 20, 2024
cjnolet
approved these changes
Nov 25, 2024
Member
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed it was missing while switching Milvus to cuVS