Brute force knn tile size heuristic #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfeher
requested changes
Sep 6, 2024
Contributor
tfeher
left a comment
tfeher
left a comment
There was a problem hiding this comment.
Thanks Malte for the PR! Could you address the two smaller issues below?
cjnolet
added
improvement
benfred
requested changes
Sep 6, 2024
Member
benfred
left a comment
benfred
left a comment
There was a problem hiding this comment.
thanks for fixing this @mfoerste4 !
|
|
||
| std::vector<IdxType>* id_ranges; | ||
| if (translations == nullptr) { | ||
| std::vector<IdxType> id_ranges; |
Member
There was a problem hiding this comment.
longer term - we can probably remove the code that handles translations entirely. Its not being used in the public api anymore, and is just left over from the RAFT version. (doesn't need to change in this PR though)
Contributor
Author
tfeher
approved these changes
Sep 11, 2024
Contributor
tfeher
left a comment
tfeher
left a comment
There was a problem hiding this comment.
Thanks Malte for the updates, LGTM!
Contributor
|
/merge |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the tile size heuristic for brute force knn as mentioned in (#277).
It also removes some unneeded cuda calls to save a couple of microseconds which might be relevant when running smaller batches.
CC @tfeher