Use CUDA math wheels #298
Merged
Use CUDA math wheels #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleFromNVIDIA
added
improvement
Member
Author
|
Comparing 934645c to this branch with the OldBuild Time: 9m4s NewBuild Time: 5m36s |
jameslamb
reviewed
Aug 20, 2024
Member
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Put up 2 small comments for your consideration. I'll return to this once our offline conversation on DLFW / devcontainers is resolved.
jameslamb
approved these changes
Aug 21, 2024
robertmaynard
approved these changes
Aug 21, 2024
cjnolet
reviewed
Aug 21, 2024
bdice
approved these changes
Aug 21, 2024
Contributor
bdice
left a comment
bdice
left a comment
There was a problem hiding this comment.
One question but it's not blocking.
Member
Author
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use CUDA math wheels to reduce wheel size by not statically linking CUDA math libraries.
Contributes to rapidsai/build-planning#35