Properly guard usage of openmp function calls #1435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
bug
github-project-automation
bot
moved this to Todo
in Vector Search, ML, & Data Mining Release Board
divyegala
reviewed
Oct 16, 2025
Member
divyegala
left a comment
divyegala
left a comment
There was a problem hiding this comment.
We could refactor the functions a bit
divyegala
reviewed
Oct 16, 2025
Member
divyegala
left a comment
divyegala
left a comment
There was a problem hiding this comment.
Related to previous comment
Contributor
Author
|
/merge |
rapids-bot
bot
merged commit 833299f
into
rapidsai:branch-25.12
162 of 164 checks passed
github-project-automation
bot
moved this from Todo
to Done
in Vector Search, ML, & Data Mining Release Board
enp1s0
pushed a commit
to enp1s0/cuvs
that referenced
this pull request
Oct 22, 2025
Proper support to disable OpenMP also requires that any calls to functions like `omp_get_max_threads` need to be guarded by a `_OPENMP` check. This is done by adding openmp wrapper functions into `cuvs/core` that properly handle the `_OPENMP` guards and behave as required when OpenMP is disabled. Required to fix rapidsai#1322 Authors: - Robert Maynard (https://github.com/robertmaynard) Approvers: - Divye Gala (https://github.com/divyegala) URL: rapidsai#1435
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proper support to disable OpenMP also requires that any calls to functions like
omp_get_max_threadsneed to be guarded by a_OPENMPcheck.This is done by adding openmp wrapper functions into
cuvs/corethat properly handle the_OPENMPguards and behave as required when OpenMP is disabled.Required to fix #1322