[Java] Make cudaGetDeviceProperties compatible with CUDA 12 and 13 based on symbol presence
#1323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Todo
in Vector Search, ML, & Data Mining Release Board
mythrocks
added
improvement
Contributor
|
/ok to test 4a680a0 |
mythrocks
approved these changes
Sep 9, 2025
Contributor
mythrocks
left a comment
mythrocks
left a comment
There was a problem hiding this comment.
This is definitely the preferable way to address this.
mythrocks
changed the title
cudaGetDeviceProperties compatible with CUDA 12 and 13 based on symbol presencecudaGetDeviceProperties compatible with CUDA 12 and 13 based on symbol presence
Contributor
|
/merge |
github-project-automation
bot
moved this from Todo
to Done
in Vector Search, ML, & Data Mining Release Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1273 we addressed a signature change in CUDA 13 by binding different symbols based on a environment variable,
RAPIDS_CUDA_MAJOR. That works, but forces users of cuvs-java with CUDA 12 to define this environment variable.This PR improves on it by making the symbol lookup dynamic, looking for the CUDA 13 symbol name, and falling back to the CUDA 12 exported name if we fail to locate the first.