[Review][Java] Expand CagraIndex#search to accept more types (int8 and int32)
#1283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Todo
in Vector Search, ML, & Data Mining Release Board
ldematte
changed the title
CagraIndex to accept more types (int8 and int32)
cjnolet
added
improvement
cjnolet
moved this from Todo
to In Progress
in Vector Search, ML, & Data Mining Release Board
ldematte
changed the title
CagraIndex to accept more types (int8 and int32)CagraIndex#search to accept more types (int8 and int32)
Contributor
Author
|
Changing this back to draft as we need #1361 as preliminary work |
rapids-bot bot
pushed a commit
that referenced
this pull request
Sep 24, 2025
…1361) This PR extract an internal interface that is used as a base to implement all internal CuVSMatrix types; the interface introduces commonly used field accessors like `memorySegment()` and `toTensor()` that we do not want/could not appear on the public interface (e.g. because they expose or require Panama types or internal types). The new interface is implemented by all concrete matrix types, closing a gap that we had in #1328 (which I realized while working on separate PRs like #1283) Follow-up of #1328 Authors: - Lorenzo Dematté (https://github.com/ldematte) Approvers: - Ben Frederickson (https://github.com/benfred) URL: #1361
…index-int8 # Conflicts: # java/cuvs-java/src/main/java22/com/nvidia/cuvs/internal/CuVSMatrixBaseImpl.java # java/cuvs-java/src/test/java/com/nvidia/cuvs/CagraBuildAndSearchIT.java # java/cuvs-java/src/test/java/com/nvidia/cuvs/CagraRandomizedIT.java
Member
|
/ok to test 3e3212f |
benfred
approved these changes
Sep 25, 2025
|
|
||
| returnValue = cuvsStreamSync(cuvsRes); | ||
| checkCuVSError(returnValue, "cuvsStreamSync"); | ||
| // TODO: do we need this stream sync here? |
Member
There was a problem hiding this comment.
I don't think you need to do this sync here - since cuvsCagraSearch is operating on the same stream
Member
|
/merge |
github-project-automation
bot
moved this from In Progress
to Done
in Vector Search, ML, & Data Mining Release Board
enp1s0
pushed a commit
to enp1s0/cuvs
that referenced
this pull request
Oct 22, 2025
…apidsai#1361) This PR extract an internal interface that is used as a base to implement all internal CuVSMatrix types; the interface introduces commonly used field accessors like `memorySegment()` and `toTensor()` that we do not want/could not appear on the public interface (e.g. because they expose or require Panama types or internal types). The new interface is implemented by all concrete matrix types, closing a gap that we had in rapidsai#1328 (which I realized while working on separate PRs like rapidsai#1283) Follow-up of rapidsai#1328 Authors: - Lorenzo Dematté (https://github.com/ldematte) Approvers: - Ben Frederickson (https://github.com/benfred) URL: rapidsai#1361
enp1s0
pushed a commit
to enp1s0/cuvs
that referenced
this pull request
Oct 22, 2025
…and int32) (rapidsai#1283) With the introduction of `CuVSMatrix` as the type to provide an input dataset, we expanded the types that can be used in indexing. With this PR we aim to do the same query/search: - Use a `CuVSMatrix` for `CagraQuery` too - Use the correct types for sizes in `CagraIndex#search` There is more we can do there, e.g. use `CuVSDeviceMatrix` for storing the results so we don't have to explicitly copy them (all duplicated code). That would be follow-up work. Authors: - Lorenzo Dematté (https://github.com/ldematte) - Ben Frederickson (https://github.com/benfred) Approvers: - Ben Frederickson (https://github.com/benfred) - Chris Hegarty (https://github.com/ChrisHegarty) URL: rapidsai#1283
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 26, 2025
…1366) Some additional tests to increase our test coverage. Good to review, but we might want to expand this after #1283 (or vice-versa, whichever comes first). Authors: - Lorenzo Dematté (https://github.com/ldematte) - MithunR (https://github.com/mythrocks) Approvers: - MithunR (https://github.com/mythrocks) URL: #1366
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of
CuVSMatrixas the type to provide an input dataset, we expanded the types that can be used in indexing.With this PR we aim to do the same query/search:
CuVSMatrixforCagraQuerytooCagraIndex#searchThere is more we can do there, e.g. use
CuVSDeviceMatrixfor storing the results so we don't have to explicitly copy them (all duplicated code). That would be follow-up work.