-
Notifications
You must be signed in to change notification settings - Fork 143
Fix debug build #1258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix debug build #1258
Conversation
Signed-off-by: Mickael Ide <[email protected]>
| if(CMAKE_BUILD_TYPE MATCHES Debug) | ||
| message(VERBOSE "cuVS: Building with debugging flags") | ||
| list(APPEND CUVS_CUDA_FLAGS -G -Xcompiler=-rdynamic) | ||
| list(APPEND CUVS_CUDA_FLAGS -G -Xcompiler=-rdynamic --maxrregcount=64) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isnt this the opposite of what we want? The warning says that 64 is too big:
ptxas warning : Too big maxrregcount value specified 64, will be ignored
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not to solve the current error on CI, this is a workaround for building in debug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lowener have you confirmed that this is the correct fix for the problem you are trying to solve with the debug build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding that flag makes the debug build succeed so yes it is solving the problem.
This flag might make the kernels slower by reducing the number of register per function but it shouldn't matter that much because the purpose of a debug build is not to be optimal speed-wise.
|
/merge |
Closes #462
Fix for the error when building in debug. It will also help downstream libraries that want to build in debug (zilliztech/knowhere#1123)