[REVIEW][Java] Rename destroyIndex() to close(), extend AutoCloseable #1252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Todo
in Vector Search, ML, & Data Mining Release Board
ldematte
changed the title
mythrocks
added
improvement
Contributor
|
Thank you for taking this up. I've been meaning to make this change myself. 100% with you here. |
Contributor
|
/ok to test ae78c15 |
Contributor
|
/ok to test 9fafec7 |
Contributor
|
/merge |
github-project-automation
bot
moved this from Todo
to Done
in Vector Search, ML, & Data Mining Release Board
Contributor
|
Argh. I should have removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The various
Indexclasses in Java all have adestroyIndexmethod that must be called in order to free resources associated with that index, when done.Other classes in the repository use
close()instead, and extend or implementAutoCloseable; this have the advantage of support in language (try-with-resources) and tooling (e.g. IntelliJ warnings).Additionally, having a single pattern is better for ease of use and consistency.
This PR renames all instances of
destroyIndextocloseand make the declaring interfaces extendAutoCloseable