Drop log level for CAGRA trace messages #1229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to rapidsai#1226, which aims to reduce the amount of noise in the Java test logs. In the course of making the changes in rapidsai#1226, one observes that there exist some TRACE messages from `libcuvs` that are being logged at the INFO level. Thousands of these fill up the Java logs, obscuring some legitimate warnings. For instance: 1. "Graph optimized, creating index" and "optimizing graph" appear 4574 times. 2. "Saving CAGRA index with dataset" appears 1025 times. There isn't any further information in the messages, beyond indicating that position in code. This commit changes the level of the first message to "TRACE", and the second to "DEBUG" (to match the logs around it). Signed-off-by: MithunR <[email protected]>
github-project-automation
bot
moved this to Todo
in Vector Search, ML, & Data Mining Release Board
Contributor
Author
|
(cc @jinsolp.) |
Signed-off-by: MithunR <[email protected]>
cjnolet
approved these changes
Aug 8, 2025
cjnolet
moved this from Todo
to In Progress
in Vector Search, ML, & Data Mining Release Board
Member
|
/merge |
github-project-automation
bot
moved this from In Progress
to Done
in Vector Search, ML, & Data Mining Release Board
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1226, which aims to reduce the amount of noise in the Java test logs.
In the course of making the changes in #1226, one observes that there exist some
TRACEmessages fromlibcuvsthat are being logged at theINFOlevel. Thousands of these fill up the Java logs, obscuring some legitimate warnings. For instance:Graph optimized, creating indexandoptimizing graphappear 4574 times.Saving CAGRA index with datasetappears 1025 times.There isn't any further information in the messages, beyond indicating that position in code.
This commit changes the level of the first message to
TRACE, and the second toDEBUG(to match the logs around it).AFAICT, this shouldn't have an effect on the tests, or have impact on user-logs, beyond reducing log volume.