Fix TieredIndexIT, Scoped resource access change was missed #1156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as missed for tieredIndex tests
github-project-automation
bot
moved this to Todo
in Vector Search, ML, & Data Mining Release Board
punAhuja
changed the title
|
|
||
| @Before | ||
| public void setup() { | ||
| assumeTrue("not supported on " + System.getProperty("os.name"), isLinuxAmd64()); |
There was a problem hiding this comment.
I think it is good for now, as it conforms with other Tests. But may be later we can get a stronger assumption that CuVSResources themselves could be created, and if not skip the test.
mayya-sharipova
approved these changes
Jul 23, 2025
mayya-sharipova
left a comment
mayya-sharipova
left a comment
There was a problem hiding this comment.
@punAhuja Thanks for a quick fix.
cjnolet
moved this from Todo
to In Progress
in Vector Search, ML, & Data Mining Release Board
cjnolet
added
bug
Contributor
|
/ok to test a515fdf |
Contributor
|
Good catch, here. LGTM, pending CI. |
Contributor
|
/ok to test 369597d |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Contributor
|
/merge |
rapids-bot
bot
merged commit bade5ee
into
rapidsai:branch-25.08
100 of 102 checks passed
github-project-automation
bot
moved this from In Progress
to Done
in Vector Search, ML, & Data Mining Release Board
lowener
pushed a commit
to lowener/cuvs
that referenced
this pull request
Aug 11, 2025
…#1156) rapidsai#1089 Scoped Resource access changes were missed in the TieredIndex test causing them to fail. - Using CheckedCuVSResources.create() now - Skip TieredIndex tests if CuVS native support is unavailable Authors: - Puneet Ahuja (https://github.com/punAhuja) Approvers: - Mayya Sharipova (https://github.com/mayya-sharipova) - MithunR (https://github.com/mythrocks) URL: rapidsai#1156
enp1s0
pushed a commit
to enp1s0/cuvs
that referenced
this pull request
Aug 22, 2025
…#1156) rapidsai#1089 Scoped Resource access changes were missed in the TieredIndex test causing them to fail. - Using CheckedCuVSResources.create() now - Skip TieredIndex tests if CuVS native support is unavailable Authors: - Puneet Ahuja (https://github.com/punAhuja) Approvers: - Mayya Sharipova (https://github.com/mayya-sharipova) - MithunR (https://github.com/mythrocks) URL: rapidsai#1156
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1089 Scoped Resource access changes were missed in the TieredIndex test causing them to fail.