[Java] Fix HNSW params allocation #1110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Todo
in Vector Search, ML, & Data Mining Release Board
Member
|
Linking cjnolet/nv_elastic#22 |
This was referenced Jul 18, 2025
mythrocks
added
improvement
Contributor
|
(Adding myself as an assignee, while working on the rebase.) |
mythrocks
changed the title
Contributor
|
/ok to test 37fc956 |
Contributor
|
/ok to test 053f9e5 |
Contributor
|
/ok to test 0a52813 |
Contributor
|
/merge |
rapids-bot
bot
merged commit 549d970
into
rapidsai:branch-25.08
100 of 102 checks passed
github-project-automation
bot
moved this from Todo
to Done
in Vector Search, ML, & Data Mining Release Board
github-project-automation
bot
moved this from In Progress
to Done
in Elasticsearch + cuVS Team Board
github-project-automation
bot
moved this from In Progress
to Done
in Elasticsearch + cuVS Team
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 29, 2025
…dIndexParamsCreate (#1147) Using `cuvsTieredIndexParamsCreate` and `cuvsTieredIndexParamsDestroy` now instead of allocating arena in Java. -Used CloseableHandle and CuvsParamsHelper as used in #1109 and #1110 for consistency This fixes #1138 Authors: - Puneet Ahuja (https://github.com/punAhuja) Approvers: - MithunR (https://github.com/mythrocks) URL: #1147
lowener
pushed a commit
to lowener/cuvs
that referenced
this pull request
Aug 11, 2025
Similar to rapidsai#1109, but for HNSW index type (a bit simpler). rapidsai#1109 replaces direct allocations of CAGRA index params (via Memory Arenas) with calls to the `cuvsCagraIndexParamsCreate()` and `cuvsCagraIndexParamsDestroy()` in the C-API. This ensures that the Java API is insulated from changes to show the C-API is implemented. The changes in this PR (rapidsai#1110) make similar changes, but for the HNSW index, and reuses the `CloseableHandle` to ensure cleanup. Authors: - Lorenzo Dematté (https://github.com/ldematte) - MithunR (https://github.com/mythrocks) Approvers: - MithunR (https://github.com/mythrocks) - Chris Hegarty (https://github.com/ChrisHegarty) URL: rapidsai#1110
lowener
pushed a commit
to lowener/cuvs
that referenced
this pull request
Aug 11, 2025
…dIndexParamsCreate (rapidsai#1147) Using `cuvsTieredIndexParamsCreate` and `cuvsTieredIndexParamsDestroy` now instead of allocating arena in Java. -Used CloseableHandle and CuvsParamsHelper as used in rapidsai#1109 and rapidsai#1110 for consistency This fixes rapidsai#1138 Authors: - Puneet Ahuja (https://github.com/punAhuja) Approvers: - MithunR (https://github.com/mythrocks) URL: rapidsai#1147
enp1s0
pushed a commit
to enp1s0/cuvs
that referenced
this pull request
Aug 22, 2025
Similar to rapidsai#1109, but for HNSW index type (a bit simpler). rapidsai#1109 replaces direct allocations of CAGRA index params (via Memory Arenas) with calls to the `cuvsCagraIndexParamsCreate()` and `cuvsCagraIndexParamsDestroy()` in the C-API. This ensures that the Java API is insulated from changes to show the C-API is implemented. The changes in this PR (rapidsai#1110) make similar changes, but for the HNSW index, and reuses the `CloseableHandle` to ensure cleanup. Authors: - Lorenzo Dematté (https://github.com/ldematte) - MithunR (https://github.com/mythrocks) Approvers: - MithunR (https://github.com/mythrocks) - Chris Hegarty (https://github.com/ChrisHegarty) URL: rapidsai#1110
enp1s0
pushed a commit
to enp1s0/cuvs
that referenced
this pull request
Aug 22, 2025
…dIndexParamsCreate (rapidsai#1147) Using `cuvsTieredIndexParamsCreate` and `cuvsTieredIndexParamsDestroy` now instead of allocating arena in Java. -Used CloseableHandle and CuvsParamsHelper as used in rapidsai#1109 and rapidsai#1110 for consistency This fixes rapidsai#1138 Authors: - Puneet Ahuja (https://github.com/punAhuja) Approvers: - MithunR (https://github.com/mythrocks) URL: rapidsai#1147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1109, but for HNSW index type (a bit simpler).
#1109 replaces direct allocations of CAGRA index params (via Memory Arenas) with calls to the
cuvsCagraIndexParamsCreate()andcuvsCagraIndexParamsDestroy()in the C-API. This ensures that the Java API is insulated from changes to show the C-API is implemented.The changes in this PR (#1110) make similar changes, but for the HNSW index, and reuses the
CloseableHandleto ensure cleanup.