[Java] Support for tiered index #1028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mythrocks
added
Java
feature request
Contributor
|
Thank you for working on this. I'm taking a look at this now. |
Contributor
Contributor
Author
|
@mythrocks Resolved the conflicts. |
mythrocks
reviewed
Jul 1, 2025
Contributor
mythrocks
left a comment
mythrocks
left a comment
There was a problem hiding this comment.
A couple of comments. Still reviewing.
java/cuvs-java/src/main/java22/com/nvidia/cuvs/internal/TieredIndexImpl.java
Outdated
Show resolved
Hide resolved
java/cuvs-java/src/main/java22/com/nvidia/cuvs/internal/TieredIndexImpl.java
Outdated
Show resolved
Hide resolved
java/cuvs-java/src/main/java22/com/nvidia/cuvs/internal/TieredIndexImpl.java
Outdated
Show resolved
Hide resolved
java/cuvs-java/src/main/java22/com/nvidia/cuvs/internal/TieredIndexImpl.java
Outdated
Show resolved
Hide resolved
java/cuvs-java/src/main/java22/com/nvidia/cuvs/internal/TieredIndexImpl.java
Show resolved
Hide resolved
mythrocks
reviewed
Jul 11, 2025
java/cuvs-java/src/main/java22/com/nvidia/cuvs/internal/TieredIndexImpl.java
Outdated
Show resolved
Hide resolved
mythrocks
requested changes
Jul 11, 2025
Contributor
mythrocks
left a comment
mythrocks
left a comment
There was a problem hiding this comment.
Need to fix how the tiered index MemorySegment is used to build the tiered index.
-extracting index pointer and using it
github-project-automation
bot
moved this to Todo
in Vector Search, ML, & Data Mining Release Board
mythrocks
changed the title
Contributor
|
I'm doing another pass on this PR. It looks good so far. I hope to approve this shortly. |
mythrocks
reviewed
Jul 15, 2025
java/cuvs-java/src/test/java/com/nvidia/cuvs/TieredIndexIT.java
Outdated
Show resolved
Hide resolved
mythrocks
reviewed
Jul 15, 2025
java/cuvs-java/src/test/java/com/nvidia/cuvs/TieredIndexIT.java
Outdated
Show resolved
Hide resolved
mythrocks
reviewed
Jul 15, 2025
java/cuvs-java/src/test/java/com/nvidia/cuvs/TieredIndexIT.java
Outdated
Show resolved
Hide resolved
mythrocks
reviewed
Jul 15, 2025
java/cuvs-java/src/main/java22/com/nvidia/cuvs/internal/TieredIndexImpl.java
Outdated
Show resolved
Hide resolved
mythrocks
requested changes
Jul 15, 2025
Contributor
mythrocks
left a comment
mythrocks
left a comment
There was a problem hiding this comment.
A couple of nitpicks more, but it looks good otherwise.
It will need a rebase again.
-Cleaned up the test and added some asserts
…puneet/expose-tiered-index
Contributor
|
/ok to test 9918bc3 |
Member
|
Linking cjnolet/nv_elastic#11 |
Contributor
|
Apologies, I haven't gotten a moment to review the latest change. I'll go over it shortly. |
Contributor
|
/ok to test 553d6a0 |
mythrocks
approved these changes
Jul 17, 2025
Contributor
mythrocks
left a comment
mythrocks
left a comment
There was a problem hiding this comment.
Alright, this looks a whole lot better. Thank you for your patience, and for incorporating the review changes.
Contributor
|
/merge |
rapids-bot
bot
merged commit 28d2de6
into
rapidsai:branch-25.08
98 of 102 checks passed
github-project-automation
bot
moved this from In Progress
to Done
in Elasticsearch + cuVS Team
github-project-automation
bot
moved this from Todo
to Done
in Vector Search, ML, & Data Mining Release Board
github-project-automation
bot
moved this from In Progress
to Done
in Elasticsearch + cuVS Team Board
Contributor
|
I've merged this change. Thank you for this one, @punAhuja. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TieredIndex exposed in the Java layer.
Code is written and tested for CAGRA algorithm only.
Serialization, Deserialization and merge is still not supported in the C layer.
Fixes: #1014