Skip to content

Conversation

@viclafargue
Copy link
Contributor

Fixes :

  • cuVS SNMG testing
  • cuVS SNMG in-place KNN merge issue

@viclafargue viclafargue requested a review from a team as a code owner June 17, 2025 09:06
@viclafargue viclafargue added bug Something isn't working non-breaking Introduces a non-breaking change labels Jun 17, 2025
@github-actions github-actions bot added the cpp label Jun 17, 2025
@benfred benfred requested a review from a team as a code owner June 17, 2025 20:05
@github-actions github-actions bot added the CMake label Jun 17, 2025
@jakirkham jakirkham requested a review from tarang-jain June 17, 2025 20:28
@jakirkham
Copy link
Member

jakirkham commented Jun 17, 2025

Seeing the following test failure on CI

FAILED tests/test_serialization.py::test_save_load_brute_force - assert np.False_
 +  where np.False_ = <function all at 0xf122c33d6870>(array([[2681,...pe=(1000, 10)) == array([[2681,...pe=(1000, 10))
 +    where <function all at 0xf122c33d6870> = np.all
    Full diff:
      array([[2681, 2868, 5268, ..., 3485, 8084, 4889],
             [ 155, 7128, 2987, ..., 7575, 3880, 1804],
             [5881, 4361,  154, ..., 4433, 3755, 1491],
             ...,
             [4352, 5289, 8310, ..., 9341, 1631, 2583],
             [8720, 4997, 6181, ..., 9647, 5247,  801],
             [7164, 2848, 2934, ..., 1141, 2924, 5954]], shape=(1000, 10),
      ))

Edit - From offline discussion, this appears to be a flaky test. Tracked in issue: #704

@jakirkham
Copy link
Member

jakirkham commented Jun 17, 2025

The rest of the builds passed. To fix the flaky test failure restarted that build

Edit: Looks like that fixed it

@AyodeAwe AyodeAwe merged commit 952fe5b into rapidsai:branch-25.06 Jun 24, 2025
143 of 146 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CMake cpp non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants