Skip to content

Conversation

@mayani-nv
Copy link
Contributor

This minor PR will add validation check for the search-mode parameter. Originally i tried to run the cuvs_bench as following

python -m cuvs_bench.run --dataset fbv6_50m --algorithms cuvs_cagra --batch-size 100 -k 10
Enter the path to dataset folder [/opt/conda/lib/python3.10/site-packages/cuvs_bench/run/datasets/]: /data/benchmarks/cuvs_experiments/datasets
Enter the comma separated groups of parameters [base]: base
Enter the search mode ("latency" or "throughput") [latency]: througput
/opt/conda/lib/python3.10/site-packages/cuvs_bench/run/run.py:187: UserWarning: Could not load YAML config

As you can see, I had the typo in this line Enter the search mode ("latency" or "throughput") [latency]: througput missing h and it defaulted to latency. This PR would print error if there's anything else specified other than latency or throughput.

@mayani-nv mayani-nv requested a review from a team as a code owner June 16, 2025 22:14
@copy-pr-bot
Copy link

copy-pr-bot bot commented Jun 16, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@tarang-jain tarang-jain added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jun 18, 2025
@divyegala
Copy link
Member

/ok to test 4432dc8

@divyegala
Copy link
Member

/ok to test 4be381c

@cjnolet
Copy link
Member

cjnolet commented Jul 8, 2025

/ok to test 7f6ddb3

@cjnolet
Copy link
Member

cjnolet commented Jul 8, 2025

/merge

@rapids-bot rapids-bot bot merged commit 8cc25c3 into rapidsai:branch-25.08 Jul 8, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change Python

Development

Successfully merging this pull request may close these issues.

4 participants