Skip to content

Conversation

@ldematte
Copy link
Contributor

The build process for Java uses jextract to generate panama bindings. Jextract is downloaded from the JDK website.
This PR excludes the downloaded Jextract archive and the Jextract files from the repository by adding them to .gitignore

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jun 11, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@cjnolet cjnolet added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jun 11, 2025
@cjnolet
Copy link
Member

cjnolet commented Jun 11, 2025

/ok to test 25547b3

Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cjnolet
Copy link
Member

cjnolet commented Jun 11, 2025

@mythrocks @ldematte CI should be fixed shortly. It's held up because we recently changed the base OS and it's exposed a couple minor bugs in our tests.

@cjnolet
Copy link
Member

cjnolet commented Jun 11, 2025

/ok to test 24e4b7f

@mythrocks
Copy link
Contributor

@mythrocks @ldematte CI should be fixed shortly. It's held up because we recently changed the base OS and it's exposed a couple minor bugs in our tests.

@cjnolet: Thank you for #1008.

@cjnolet
Copy link
Member

cjnolet commented Jun 12, 2025

/merge

@rapids-bot rapids-bot bot merged commit 969d633 into rapidsai:branch-25.08 Jun 12, 2025
99 of 102 checks passed
bkarsin pushed a commit to bkarsin/cuvs that referenced this pull request Jun 19, 2025
The build process for Java uses `jextract` to generate panama bindings. Jextract is downloaded from the JDK website.
This PR excludes the downloaded Jextract archive and the Jextract files from the repository by adding them to `.gitignore`

Authors:
  - Lorenzo Dematté (https://github.com/ldematte)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - MithunR (https://github.com/mythrocks)

URL: rapidsai#1005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Development

Successfully merging this pull request may close these issues.

3 participants