Skip to content

Conversation

betatim
Copy link
Member

@betatim betatim commented Aug 26, 2025

This addsAgglomerativeClustering to the list of estimators that get tested with the common tests

@jcrist jcrist added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 26, 2025
@betatim
Copy link
Member Author

betatim commented Aug 27, 2025

Of course it is not this easy.

The first test that fails is related to pickling. But in my experience the "bug" is often in a test before the one that fails. The annoying thing is that this doesn't happen locally, which makes it harder to bisect the tests to find the offender.

FAILED test_sklearn_compatibility.py::test_sklearn_compatible_estimator[AgglomerativeClustering()-check_estimators_pickle] - MemoryError: std::bad_alloc: CUDA error (failed to allocate 368 bytes) at: /opt/conda/envs/test/include/rmm/mr/device/cuda_memory_resource.hpp

@csadorf
Copy link
Contributor

csadorf commented Sep 3, 2025

Is this ready for review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants