UMAP batch nnd test hotfix #6826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinsolp
added
! - Hotfix
csadorf
added
bug
divyegala
reviewed
May 30, 2025
cpp/src/umap/knn_graph/algo.cuh
Outdated
| RAFT_CUDA_TRY(cudaPointerGetAttributes(&attr, inputsA.X)); | ||
| float* ptr = reinterpret_cast<float*>(attr.devicePointer); | ||
| bool data_on_device = ptr != nullptr; | ||
| float* ptr = reinterpret_cast<float*>(attr.hostPointer); |
Member
There was a problem hiding this comment.
Do pointers allocated with new and malloc also have a valid attr.hostPointer?
Contributor
|
Looks like the patch does not work on CUDA 11. |
divyegala
approved these changes
May 30, 2025
Member
divyegala
left a comment
divyegala
left a comment
There was a problem hiding this comment.
Here's @robertmaynard's relevant PR, and why I believe this fix is correct: rapidsai/raft#2480
Contributor
Author
|
Checked that this fix works on the GH system too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/rapidsai/ml-planning/issues/6