Skip to content

Conversation

@Matt711
Copy link
Contributor

@Matt711 Matt711 commented Nov 7, 2025

Description

Justification: The new rapidsmpf runtime is in flux, so nighlies can break frequently.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 requested a review from a team as a code owner November 7, 2025 16:45
@Matt711 Matt711 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 7, 2025
Copy link
Member

@rjzamora rjzamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird - I could have sworn continue-on-error: true was already there when this was first added. Sorry about that!

@TomAugspurger
Copy link
Contributor

@rockhowse rockhowse merged commit 36c811f into rapidsai:main Nov 7, 2025
92 of 95 checks passed
@Matt711
Copy link
Contributor Author

Matt711 commented Nov 7, 2025

The error at https://github.com/rapidsai/cudf/actions/runs/19175022030/job/54820199137?pr=20550#step:12:60454 is fixed on main. I think this branch is just a bit behind (https://github.com/Matt711/cudf/blob/8022c2e4c82bdb1a7eadbc96f3ef03bb4a86abfa/python/cudf_polars/cudf_polars/experimental/rapidsmpf/utils.py#L95).

That job might be non-blocking though.

Thanks, the nightly CI check was blocking. So I request an admin merge

@rjzamora
Copy link
Member

rjzamora commented Nov 7, 2025

It's strange the the cudf-polars + rapidsmpf tests were failing here. That CI job was using an old version of cudf-polars for some reason?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants