Skip to content

Use faster unaligned_load_unsafe when possible #20543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Use faster unaligned_load_unsafe when possible #20543

wants to merge 6 commits into from
+96 −64

Conversation

@mhaseeb123
Copy link
Member

@mhaseeb123 mhaseeb123 commented Nov 7, 2025 •
edited
Loading

Description

Follow up of #20458

This PR re-enables the use of the faster unaligned_load_unsafe when possible.

Checklist

  • Run benchmarks
  • Run compute sanitizer memcheck
  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 7, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Nov 7, 2025
@mhaseeb123 mhaseeb123 added 2 - In Progress Currently a work in progress cuIO cuIO issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 7, 2025
@mhaseeb123 mhaseeb123 marked this pull request as ready for review November 7, 2025 02:39
@mhaseeb123 mhaseeb123 requested a review from a team as a code owner November 7, 2025 02:39
@mhaseeb123 mhaseeb123 marked this pull request as draft November 7, 2025 02:39
@mhaseeb123
Copy link
Member Author

mhaseeb123 commented Nov 7, 2025

Whoops, accidentally marked as Ready for review. Wll run and add benchmark results here tomorrow.

@mhaseeb123 mhaseeb123 moved this to Burndown in libcudf Nov 7, 2025
bdice
bdice approved these changes Nov 7, 2025
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's always dark magic in these parts of the I/O code... if this passes memchecks we should be good.

edit: I see the comment above about benchmarks. Happy to re-review once that's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdice bdice bdice approved these changes

@karthikeyann karthikeyann Awaiting requested review from karthikeyann karthikeyann is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@davidwendt davidwendt Awaiting requested review from davidwendt davidwendt is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@mhaseeb123 mhaseeb123

Labels

2 - In Progress Currently a work in progress cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

libcudf
Status: Burndown

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mhaseeb123 @bdice