Skip to content

Conversation

davidwendt
Copy link
Contributor

Description

Fixes some build failures from the nightly tests https://github.com/rapidsai/cudf/actions/runs/16258662170/job/45899486553

 │ │ $SRC_DIR/cpp/tests/io/parquet_common.cpp:507:26: error: '%09d' directive writing between 9 and 11 bytes into a region of size 10 [-Werror=format-overflow=]
 │ │   507 |     sprintf(buf.data(), "%09d", (i % 2 == 0) ? i : (num_ordered_rows - i));

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt self-assigned this Jul 14, 2025
@davidwendt davidwendt requested a review from a team as a code owner July 14, 2025 12:56
@davidwendt davidwendt requested review from shrshi and ttnghia July 14, 2025 12:56
@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Jul 14, 2025
@davidwendt davidwendt marked this pull request as draft July 14, 2025 22:02
Copy link

copy-pr-bot bot commented Jul 14, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@davidwendt
Copy link
Contributor Author

Changing this to draft until the gcc compiler can be updated in the pip devcontainer to 13 or higher.

@vyasr
Copy link
Contributor

vyasr commented Jul 15, 2025

@davidwendt can we close this now that #19371 is merged?

@davidwendt
Copy link
Contributor Author

davidwendt commented Jul 15, 2025

@davidwendt can we close this now that #19371 is merged?

No. I was planning to merge this once we move to gcc 14.
Or rapidsai/devcontainers#534 this gets merged. Whichever is first.

@vyasr
Copy link
Contributor

vyasr commented Jul 16, 2025

JFYI at this point I'm probably going to punt the compiler update to 25.10 to avoid breaking anything mid burndown.

@davidwendt davidwendt changed the base branch from branch-25.08 to branch-25.10 July 24, 2025 12:58
@davidwendt
Copy link
Contributor Author

/ok to test

@davidwendt
Copy link
Contributor Author

/ok to test

@vyasr
Copy link
Contributor

vyasr commented Jul 30, 2025

@davidwendt the conda and wheel builds have moved to gcc 14 and the devcontainers PR linked above is also merged, so you should be safe to open this PR for review now.

@davidwendt
Copy link
Contributor Author

/ok to test

@davidwendt davidwendt marked this pull request as ready for review August 6, 2025 14:53
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 0456b16 into rapidsai:branch-25.10 Aug 7, 2025
90 checks passed
@davidwendt davidwendt deleted the remove-sprintf branch August 7, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants