-
Notifications
You must be signed in to change notification settings - Fork 971
Replace sprintf with std::format in libcudf parquet tests #19364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Changing this to draft until the gcc compiler can be updated in the pip devcontainer to 13 or higher. |
@davidwendt can we close this now that #19371 is merged? |
No. I was planning to merge this once we move to gcc 14. |
JFYI at this point I'm probably going to punt the compiler update to 25.10 to avoid breaking anything mid burndown. |
/ok to test |
/ok to test |
@davidwendt the conda and wheel builds have moved to gcc 14 and the devcontainers PR linked above is also merged, so you should be safe to open this PR for review now. |
/ok to test |
/merge |
Description
Fixes some build failures from the nightly tests https://github.com/rapidsai/cudf/actions/runs/16258662170/job/45899486553
Checklist