Update cudf to accommodate breaking changes in cuCollections #19093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
libcudf
|
/ok to test 9d2b58c |
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Not intended for review yet, just testing for correctness at this stage. |
PointKernel
added
2 - In Progress
7 tasks
|
/ok to test 7091e3d |
PointKernel
added
2 - In Progress
|
@bdice @lamarrr This PR is ready for review. Once rapidsai/rapids-cmake#861 is merged, I’ll revert the CMake changes in this PR and rerun CI. Note that CI will be broken in the interim—after the |
PointKernel
added
4 - Needs Review
bdice
approved these changes
Jun 7, 2025
PointKernel
commented
Jun 9, 2025
| probing_scheme_t, | ||
| cuco::bucket_storage_ref<cudf::size_type, | ||
| GROUPBY_BUCKET_SIZE, | ||
| cuco::valid_extent<int64_t, cuco::dynamic_extent>>, |
There was a problem hiding this comment.
@sleeepyjack We might want to add the default dynamic_extent back, since this isn't a fully detailed implementation as shown here.
PointKernel
added
5 - Ready to Merge
|
/merge |
6 tasks
mhaseeb123
added a commit
to mhaseeb123/cudf
that referenced
this pull request
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates cudf to align with the recent breaking changes in cuco's new storage design introduced in NVIDIA/cuCollections#694.
Checklist