Pin rubyzip version until we can upgrade #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgranleese-r7
approved these changes
Sep 16, 2025
|
Note: To whomever unpins this, we should ensure Pro's backup functionality works as expected - since it's using ruby zip too |
|
@ptownes-r7 Spiked this briefly, looks like we're blocked on Pro+framework+metasploit-credential code changes plus an external dependency bump #194 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby zip has released version 3.X which includes breaking changes https://github.com/rubyzip/rubyzip/wiki/Updating-to-version-3.x
I've just pinned the version for now until we have the time to properly investigate the changes and update as necessary