Resolve TODO comments in socket utilities #5127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Botan Developer Team,
This pull request contains some TODO message resolves for socket utilities;
inet_ptonwithstring_to_ipv4for IPv4 validationstrerror_sper TODO comment - WindowsI don't except there to be any behavioral difference here. I believe I tested it by compiling with the following command on the Linux but need more additional testing. For Windows I will investigate the situation in CI.
Regards.