Deprecate ember-based UI Plugins #5230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses rancher/dashboard#14286
This PR changes re-uses the RKE1 deprecation banner for deprecation of Ember-based UI plugins.
It also fixes a bug with the code that handles error loading custom javascript for a plugin and now correctly handles this and shows an error on the creation screen when this happens - previously users get a partially-rendered page.
To test:
Open Telekom Cloud CCEGo to create and choose this driver.
Check that the page shows the new deprecation banner:
Go the Drivers and edit the for the drvier - add some junk to the end of the URL, eg:
Reload the UI (since the plugin is cached and we need to reload to remove it)
Go to the cluster create again and verify that the page shows the new error message and not a partially-rendered form: