Skip to content

RKE2 package re-work for recurring runs. #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2025
Merged

RKE2 package re-work for recurring runs. #169

merged 1 commit into from
Jul 31, 2025

Conversation

susesgartner
Copy link
Contributor

Summary: The goal of this PR is to prepare our automation to be added to recurring runs by shortening the configs, allowing parallelism across and remove various components that were no longer necessary.

Changes:

  • Removed Testify from all tests in the rke2 package (testify assertions is an exception)
  • Changed the build tags to what we are going to be using for our recurring runs
  • Added parallelism at the test and table test levels so we can run multiple tests and their table tests at the same time from a single command
  • Added a defaults system that allows for non-sensitive fields to be ignored if the user chooses.
  • Renamed the tests to remove redundancy.
  • Split the dynamic tests out from the release tests (this was needed due to build tag constraints)
  • Removed the hard coded load of the EC2Configs from the custom cluster and updated all affected tests (this was done because it was bypassing defaults)

markusewalker
markusewalker reviewed Jul 29, 2025
View reviewed changes
Copy link
Contributor

@markusewalker markusewalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, but overall the functionality is good.

Josh-Diamond
Josh-Diamond reviewed Jul 30, 2025
View reviewed changes
Copy link
Contributor

@Josh-Diamond Josh-Diamond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review LGTM -- will await requested changes from other reviewers before approving

@susesgartner susesgartner force-pushed the RKE2-recurring branch 2 times, most recently from 33c3b0c to 1c32065 Compare July 30, 2025 19:02
slickwarren
slickwarren previously approved these changes Jul 30, 2025
View reviewed changes
Copy link
Collaborator

@slickwarren slickwarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirming this is OK from PIT crew perspective 👍🏼

@susesgartner susesgartner marked this pull request as ready for review July 30, 2025 20:57
@susesgartner susesgartner requested review from a team as code owners July 30, 2025 20:57
markusewalker
markusewalker approved these changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@markusewalker markusewalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@susesgartner
rke2 package updates
dfdd492 
update

update

Add more tests

Update custom and parallelism

update custom cluster

agent/ace tests

fixes

Update README.md

lint fix
@susesgartner susesgartner merged commit a291358 into rancher:main Jul 31, 2025
3 checks passed
@susesgartner susesgartner mentioned this pull request Jul 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Diamond Josh-Diamond Josh-Diamond approved these changes

@markusewalker markusewalker markusewalker approved these changes

@slickwarren slickwarren slickwarren left review comments

@navsalehi navsalehi Awaiting requested review from navsalehi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@susesgartner @slickwarren @Josh-Diamond @markusewalker